Tab link #4
Notifications
Due Date
No due date set.
Blocks
Reference: gamv/ds2-core#4
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Might be helpful to be able to provide a link to a specific tab within a pattern. This would need to allow for link generation, as well as link detection and activation
Triggering a click on the tab will activate it. We can do this using the document.location.hash.
Triggering the correct tab is working, but it's also generating a JS error that we should fix before we close this issue.
The link generation should be done in the core. and then should be documented how to implement it in your project for projects that are using the tabs in their own design system and generating the link might be unique in each project's case.
For DS2, it should probably generate a link that also contains the specific pattern and it should be in _core.js. This is not because there could be a conflict, but because finding the activated tab without knowing which pattern would be a pain.
It's not reliably opening the tab.
Let’s leave this open and we’ll get the tabs added to the history. With the URL changing you can select the tab and and copy the URL. This will allow us to deprecate the click states.