gamv/ds2-core
1
0
Fork 0
Code Issues 13 Releases 8 Activity

Colour Module: CSS output puts out wrong comma instead of semicolon #21

New Issue
Closed
opened 2024-10-11 14:09:34 -04:00 by am · 0 comments
am commented 2024-10-11 14:09:34 -04:00
Owner
Copy Link

Actual result: --color-blue: #2e51a1,
Expected result: --color-blue: #2e51a1;
The colour module outputs the wrong line ending at the end of a colour token. This only happens for the CSS output. SCSS uses a comma in the mixin and outputs a semicolon when looping over the colours.

I think the lines that need fixing include src/pg/core/_colour-samples.pug : 131, 133, 136

Actual result: --color-blue: #2e51a1, Expected result: --color-blue: #2e51a1; The colour module outputs the wrong line ending at the end of a colour token. This only happens for the CSS output. SCSS uses a comma in the mixin and outputs a semicolon when looping over the colours. I think the lines that need fixing include src/pg/core/_colour-samples.pug : 131, 133, 136
am added the
Kind/Bug
Priority
1 High
 labels 2024-10-11 14:09:34 -04:00
am referenced this issue from a commit 2024-10-18 18:19:56 -04:00
Fixes #21
am closed this issue 2024-10-18 18:19:57 -04:00
am added this to the <= v1.1 milestone 2025-05-14 20:32:44 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Core
Pattern/Colours
Pattern/Status
Pattern/Tabs
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Build process
Issues with build processes or scripts
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature request
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Kind/User experience
Issues with user experience that should be considered and fixed
Priority
0 Critical
The priority is critical
Priority
1 High
The priority is high
Priority
2 Medium
The priority is medium
Priority
3 Low
The priority is low
Status/Blocked
Something is blocking this issue or pull request
Status/Duplicate
This issue or pull request already exists
Status/Need More Info
Feedback is required to reproduce issue or to continue work
Status/Won't Fix
This issue won't be fixed
No Label
Kind/Bug
Priority
1 High
Milestone
No items
No Milestone <= v1.1
Assignees
Clear assignees
am
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gamv/ds2-core#21
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?