gamv/ds2-core
1
0
Fork 0
Code Issues12 Releases8 Activity

Colour Module: CSS output puts out wrong comma instead of semicolon #21

New Issue
Closed
opened 2024-10-11 14:09:34 -04:00 by am · 0 comments
am commented 2024-10-11 14:09:34 -04:00
Owner

Actual result: --color-blue: #2e51a1,
Expected result: --color-blue: #2e51a1;
The colour module outputs the wrong line ending at the end of a colour token. This only happens for the CSS output. SCSS uses a comma in the mixin and outputs a semicolon when looping over the colours.

I think the lines that need fixing include src/pg/core/_colour-samples.pug : 131, 133, 136

Actual result: --color-blue: #2e51a1, Expected result: --color-blue: #2e51a1; The colour module outputs the wrong line ending at the end of a colour token. This only happens for the CSS output. SCSS uses a comma in the mixin and outputs a semicolon when looping over the colours. I think the lines that need fixing include src/pg/core/_colour-samples.pug : 131, 133, 136
am added the
Kind/Bug
Priority
1 High
 labels 2024-10-11 14:09:34 -04:00
am referenced this issue from a commit 2024-10-18 18:19:56 -04:00
Fixes #21
am closed this issue 2024-10-18 18:19:57 -04:00
Sign in to join this conversation.
No Label
Core
Pattern/Colours
Pattern/Status
Pattern/Tabs
Kind/Breaking
Kind/Bug
Kind/Build process
Kind/Documentation
Kind/Enhancement
Kind/Feature request
Kind/Security
Kind/Testing
Kind/User experience
Priority
0 Critical
Priority
1 High
Priority
2 Medium
Priority
3 Low
Status/Blocked
Status/Duplicate
Status/Need More Info
Status/Won't Fix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gamv/ds2-core#21
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?