Slow loading on larger design systems #2
Labels
No Label
Core
Pattern/Status
Pattern/Tabs
Kind/Breaking
Kind/Bug
Kind/Build process
Kind/Documentation
Kind/Enhancement
Kind/Feature request
Kind/Security
Kind/Testing
Kind/User experience
Priority
0 Critical
Priority
1 High
Priority
2 Medium
Priority
3 Low
Status/Blocked
Status/Duplicate
Status/Need More Info
Status/Won't Fix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gamv/ds2-core#2
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
the small set of patterns in ds-core load without too much trouble; however, I've noted on two larger design systems, it's rather slow. Consider an intersection observer to load patters as they come into view rather than all at the beginning.
Observer is mostly working. Needs to unobserve otherwise patterns are getting loaded a second time. Also had to remove the rootMargin, as this was generating an error when compiling in prepros. Once we have figured out how resolve that error this can be fixed.
Attempted to fix this with Intersection observer alone didn't work. Still loads more content than is on screen.
Attempted to default articles to larger (1.5vh) didn't help. Content in two sections down was loaded and flagged as 404.
Moving to Prism.highlightAllUnder(a); doesn't seem to help, but doesn't make things worse, so probably best to have it only try to highlight the current article's code blocks.
Changed rootMargin up to 100% from half window in px ((document.body.clientHeight / 2) + "px") and added a temporary 100vh height to the articles. Changed to root margin seems to have been a huge factor.