gamv/ds2-core
1
0
Fork 0
Code Issues 13 Releases 8 Activity

Menu code doesn't work if the structure is different #1

New Issue
Closed
opened 2024-07-13 20:31:05 -04:00 by am · 1 comment
am commented 2024-07-13 20:31:05 -04:00
Owner
Copy Link

JavaScript error occurs in core.init if the nav takes a different form. Move to a callback should be sufficient for now for any things that might require a change for the nav.

Eventually, we should find a way to handle it through navigation pattern.

I'll keep this open until we find another way to handle this.

JavaScript error occurs in core.init if the nav takes a different form. Move to a callback should be sufficient for now for any things that might require a change for the nav. Eventually, we should find a way to handle it through navigation pattern. I'll keep this open until we find another way to handle this.
am added the
Kind/Bug
 label 2024-07-13 20:31:05 -04:00
am commented 2024-07-16 04:11:59 -04:00
Author
Owner
Copy Link

Added handlers for beforeArticleLoad and afterArticleLoad load core.init and documented these in readme.md.

Added handlers for beforeArticleLoad and afterArticleLoad load core.init and documented these in readme.md.
am closed this issue 2024-07-16 04:11:59 -04:00
am added this to the <= v1.1 milestone 2025-05-14 20:31:32 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Core
Pattern/Colours
Pattern/Status
Pattern/Tabs
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Build process
Issues with build processes or scripts
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature request
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Kind/User experience
Issues with user experience that should be considered and fixed
Priority
0 Critical
The priority is critical
Priority
1 High
The priority is high
Priority
2 Medium
The priority is medium
Priority
3 Low
The priority is low
Status/Blocked
Something is blocking this issue or pull request
Status/Duplicate
This issue or pull request already exists
Status/Need More Info
Feedback is required to reproduce issue or to continue work
Status/Won't Fix
This issue won't be fixed
No Label
Kind/Bug
Milestone
No items
No Milestone <= v1.1
Assignees
Clear assignees
am
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gamv/ds2-core#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?